davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Concept is fine.
I think you have a typo in the last method.
INLINE COMMENTS
> notificationsapplet.cpp:137
> + if (newPopupPosition != m_popupPosition) {
> + Q_EMIT screenPositionChanged(m_popupPosition);
> + }
you're not updating m_popupPosition
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8819
To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
