mwolff requested changes to this revision. mwolff added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > foldermodel.cpp:1071 > + m_dropTargetPositions.insert(url.fileName(), dropPos); > + m_screenMapper->addMapping(mappableUrl(url), m_screen, > ScreenMapper::DelayedSignal); > + } unguarded > foldermodel.cpp:1123 > + if (targetUrl.toString().startsWith(url.toString())) { > + m_screenMapper->addMapping(targetUrl.toString(), > m_screen, ScreenMapper::DelayedSignal); > + } else if > (targetUrl.toString().startsWith(dropTargetUrl.toString())) { unguarded > foldermodel.cpp:1131 > + url.setPath(filePath.remove(0, destPath.length())); > + m_screenMapper->addMapping(url.toString(), m_screen, > ScreenMapper::DelayedSignal); > + } unguarded REVISION DETAIL https://phabricator.kde.org/D8850 To: amantia, mwolff, #plasma, hein Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart