anthonyfieroni added inline comments. INLINE COMMENTS
> arichardson wrote in kdeplatformfiledialoghelper.cpp:365-370 > I don't think we can depend on that yet, can we? Also I'm not sure we really > need that runtime check. How likely is it that someone compiles plasma > integration against Qt 5.7 and runs it with 5.8? Is that even supported? > Aren't we using private APIs? > How likely is it that someone compiles plasma integration against Qt 5.7 and > runs it with 5.8? It's likely (hypothetical), complied with 5.8 and run it with 5.7 is unsupported. > Is that even supported? It's supported by Qt, by KDE pretty sure - not. I'm not stopper of this change, Elvis should accept it. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D4193 To: arichardson, #plasma Cc: ngraham, krzyc, anthonyfieroni, elvisangelaccio, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
