broulik added inline comments.
INLINE COMMENTS
> foldermodel.cpp:124
> + m_complete(false),
> + m_screenMapper(ScreenMapper::instance())
> {
Why have this member then?
> foldermodel.cpp:194
>
> + connect(m_screenMapper, &ScreenMapper::screensChanged, this,
> &FolderModel::invalidateFilterIfComplete);
> + connect(m_screenMapper, &ScreenMapper::screenMappingChanged, this,
> &FolderModel::invalidateFilterIfComplete);
I think we shouldn't connect to the signals if we're not a containment?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9323
To: amantia, #plasma, mwolff, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
