sebas requested changes to this revision.
sebas added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> OsdSelector.qml:49
> +                        iconSource: "osd-shutd-screen",
> +                        label: qsTr("Switch to external screen"),
> +                        action: OsdAction.SwitchToExternal

i18n() instead of qsTr()

> OsdSelector.qml:54
> +                        iconSource: "osd-shutd-laptop",
> +                        label: qsTr("Switch to laptop screen"),
> +                        action: OsdAction.SwitchToInternal

i18n() instead of qsTr()

> OsdSelector.qml:59
> +                        iconSource: "osd-duplicate",
> +                        label: qsTr("Duplicate outputs"),
> +                        action: OsdAction.Clone

i18n() instead of qsTr(), perhaps clone or unify? (Unify is used elsewhere in 
the UI)

> OsdSelector.qml:64
> +                        iconSource: "osd-sbs-left",
> +                        label: qsTr("Extend to left"),
> +                        action: OsdAction.ExtendLeft

i18n() instead of qsTr()

> OsdSelector.qml:69
> +                        iconSource: "osd-sbs-sright",
> +                        label: qsTr("Extend to right"),
> +                        action: OsdAction.ExtendRight

i18n() instead of qsTr()

> OsdSelector.qml:74
> +                        iconSource: "dialog-cancel",
> +                        label: qsTr("Do nothing"),
> +                        action: OsdAction.NoAction

Perhaps "Leave unchanged"?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D9414

To: dvratil, sebas, davidedmundson, #vdg
Cc: abetts, broulik, kamathraghavendra, graesslin, ngraham, plasma-devel, 
mlaurent, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, mart

Reply via email to