apol added a comment.
I like it, some nitpicking: F5664327: Screenshot_20180119_204906.png <https://phabricator.kde.org/F5664327> This is the application delegate, I think it would make sense to do the same use of the blue line that is here. Also I would remove the blue line under Details much like we don't have it under Description at the moment. INLINE COMMENTS > ApplicationPage.qml:227 > Kirigami.Heading { > - text: appInfo.application.comment > - level: 4 > + text: i18n("Details") > + level: 3 This is a new string. Can't have new strings for 5.12. REPOSITORY R134 Discover Software Store BRANCH combobox-to-choose-source REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, #discover_software_store, #vdg, andreaska Cc: andreaska, januz, romangg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
