graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.
REVISION SUMMARY KDecoration has two new pure virtual methods. Due to that one cannot build KWin in the stable branch. This makes bug fixing rather cumbersome as one also needs to switch the kdecoration branch. This rather unusual change for a stable branch improves the compatibility by adding the new virtual methods without doing anything and without marking them as override, so that the code can compile with a kdecoration from 5.12 and a kdecoration from master. TEST PLAN 5.12 branch compiles with kdecoration master branch REPOSITORY R108 KWin BRANCH compile-5.12-with-kdecoration-master REVISION DETAIL https://phabricator.kde.org/D10296 AFFECTED FILES decorations/decoratedclient.cpp decorations/decoratedclient.h kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp kcmkwin/kwindecoration/declarative-plugin/previewclient.h To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart