Hi David,
Thanks for the report! In KDE, we typically track these kinds of issues with bugzilla tickets, so I would recommend that you file one for it. Here is the documentation for that: https://community.kde.org/Get_Involved#Bug_Reporting

If you would like to submit a patch for the issue, Please see https://community.kde.org/Infrastructure/Phabricator



On 02/08/2018 02:07 AM, David Binderman wrote:
Hello there,

plasma-desktop-5.12.0/kcms/kfontinst/lib/Misc.cpp:294]: (style) Same expression on both sides of '||'.

Source code is

     return "font/otf"==mime || "font/ttf"==mime ||
           "application/x-font-type1"==mime || "application/x-font-ttf"==mime ||            "application/x-font-otf"==mime || "application/x-font-type1"==mime;

x-font-type1 gets mentioned twice. Suggest code rework.


David Binderman

Reply via email to