mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.
Otherwise patch is correct.
INLINE COMMENTS
> firefox.cpp:58
> if (m_dbCacheFile.isEmpty()) {
> - m_dbCacheFile =
> QStandardPaths::writableLocation(QStandardPaths::CacheLocation) +
> QStringLiteral("bookmarkrunnerfirefoxdbfile.sqlite");
> + m_dbCacheFile =
> QStandardPaths::writableLocation(QStandardPaths::CacheLocation) + "/" +
> QStringLiteral("bookmarkrunnerfirefoxdbfile.sqlite");
> }
or QStringLiteral("/bookmarkrunnerfirefoxdbfile.sqlite"); directly.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10605
To: z3ntu, mlaurent
Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
