davidedmundson added a comment.
I'd do reviews on the other two, because there's a mistake in your commit message: > The other eventType are "windows_generic_MSG" and "mac_generic_NSEvent". QAbstractEventDispatcher::filterNativeEvent is public. Client code could be using that for anything, clients are weird. We know what Plasma is doing, but that's not true for the Frameworks case. REPOSITORY R120 Plasma Workspace BRANCH polling (branched from master) REVISION DETAIL https://phabricator.kde.org/D10627 To: jtamate, #frameworks, #plasma, davidedmundson Cc: broulik, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart