jtamate added a comment.
In D10670#209823 <https://phabricator.kde.org/D10670#209823>, @mwolff wrote: > ok, looking at the reasoning in the other commit: > > - you need to extend the commit message here Will be done. > - you need to provide a comment in the code the clarifies what's going on here Will be done. > in general, I don't see how such a comparison can be so costly - the real problem would be too many native events, no? did you maybe profile a debug build or something? A qstrcmp is more expensive than a single cpu instruction in i586 builds (debug or release), unless it uses SSE4 instruction in the x64 world. Unfortunately I haven't found what causes so many native events. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10670 To: jtamate, #frameworks, #plasma, mwolff Cc: mwolff, plasma-devel, davidedmundson, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
