sebas added a comment.
OsdManager::showActionSelector() will delete existing OSDs before showing a new one, so we won't create multiple OSDs. That's arguably not as nice as tracking if it's already shown, but I think I'd rather avoid the added complexity of adding a check if it's already there, if that's OK from your POV. As to the other cleanups: Good point, I'll submit an updated version of this patch shortly. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D10896 To: sebas, #plasma, dvratil Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart