xuetianweng added inline comments. INLINE COMMENTS
> panel.cpp:1031 > impanel->xkbLayoutManager = new XkbLayoutManager; > + impanel->settings_general = g_settings_new (IBUS_SCHEMA_GENERAL); > + impanel->settings_hotkey = g_settings_new (IBUS_SCHEMA_HOTKEY); IMHO you need to g_object_unref this two new settings in ibus_panel_impanel_destroy. > panel.cpp:1033 > + impanel->settings_hotkey = g_settings_new (IBUS_SCHEMA_HOTKEY); > + g_signal_connect(impanel->settings_general, "changed", G_CALLBACK > (impanel_settings_changed_callback), impanel); > + g_signal_connect(impanel->settings_hotkey, "changed", G_CALLBACK > (impanel_settings_changed_callback), impanel); and disconnect the signal too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein, xuetianweng Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
