Hi Ben,

I pushed a possible fix. No guarnatees as this code obviously compiled on my system.

Could the compiler settings please be adjusted so that we have warnings be warnings on all ci systems and not fail on randomly? This was rather unexpected for me and makes it quite difficult to properly test before hand. The firefighting afterwards is something I don't like as mails with "fix this as soon as possible" are difficult if you don't have much time.

Cheers
Martin

Am 2018-03-24 11:25, schrieb Ben Cooksley:
Hi Martin,

Please see below. Could you please fix this as soon as possible?

This is blocking all FreeBSD Dependency builds meaning any change to
the binary compatibility state of the FreeBSD platform will break the
whole CI system on FreeBSD.

Cheers,
Ben

On Wed, Mar 21, 2018 at 6:51 PM, CI System <nore...@kde.org> wrote:

BUILD FAILURE

Build URL

https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/15/
[1]

Project:
Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9

Date of build:
Wed, 21 Mar 2018 05:50:19 +0000

Build duration:
1 min 31 sec and counting

CONSOLE OUTPUT

[...truncated 92.62 KB...]

[ 10%] Building CXX object

src/CMakeFiles/KF5WindowSystem.dir/ECMQmLoader-kwindowsystem5_qt.cpp.o

[ 11%] Building CXX object

src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kselectionowner.cpp.o

[ 12%] Building CXX object

src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kselectionwatcher.cpp.o

[ 12%] Building CXX object

src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxerrorhandler.cpp.o

[ 13%] Building CXX object
src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxutils.cpp.o

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kxerrorhandler.cpp:145:10: warning:
unused variable 'num' [-Wunused-variable]

char num[ 256 ];

^

1 warning generated.

[ 14%] Building CXX object
src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kkeyserver.cpp.o

[ 15%] Building CXX object
src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxmessages.cpp.o

[ 16%] Building CXX object
src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/netwm.cpp.o

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:524:27: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

keySymX = XKeycodeToKeysym(QX11Info::display(),
xmk->modifiermap[xmk->max_keypermod * i + j], k);

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:719:20: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

if (sym == XKeycodeToKeysym(QX11Info::display(), code, 0))

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:721:25: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 1)) {

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:723:27: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

} else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 2))
{

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:725:27: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

} else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 3))
{

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:917:20: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

uint sym = XKeycodeToKeysym(QX11Info::display(), keyCodeX, 0);

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

[ 16%] Building CXX object

src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_autogen/mocs_compilation.cpp.o

6 warnings generated.

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2762:25: warning: cast from
'unsigned char *' to 'uint32_t *' (aka 'unsigned int *') increases
required alignment from 1 to 4 [-Wcast-align]

uint32_t *d32 = (uint32_t *) icons[i].data;

^~~~~~~~~~~~~~~~~~~~~~~~~~

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2846:13: error:
non-constant-expression cannot be narrowed from type 'int' to
'uint32_t' (aka 'unsigned int') in initializer list
[-Wc++11-narrowing]

topology.top, topology.bottom, topology.left, topology.right, 1

^~~~~~~~~~~~

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2846:13: note: insert an
explicit cast to silence this issue

topology.top, topology.bottom, topology.left, topology.right, 1

^~~~~~~~~~~~

static_cast<uint32_t>( )

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2846:27: error:
non-constant-expression cannot be narrowed from type 'int' to
'uint32_t' (aka 'unsigned int') in initializer list
[-Wc++11-narrowing]

topology.top, topology.bottom, topology.left, topology.right, 1

^~~~~~~~~~~~~~~

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2846:27: note: insert an
explicit cast to silence this issue

topology.top, topology.bottom, topology.left, topology.right, 1

^~~~~~~~~~~~~~~

static_cast<uint32_t>( )

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2846:44: error:
non-constant-expression cannot be narrowed from type 'int' to
'uint32_t' (aka 'unsigned int') in initializer list
[-Wc++11-narrowing]

topology.top, topology.bottom, topology.left, topology.right, 1

^~~~~~~~~~~~~

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2846:44: note: insert an
explicit cast to silence this issue

topology.top, topology.bottom, topology.left, topology.right, 1

^~~~~~~~~~~~~

static_cast<uint32_t>( )

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2846:59: error:
non-constant-expression cannot be narrowed from type 'int' to
'uint32_t' (aka 'unsigned int') in initializer list
[-Wc++11-narrowing]

topology.top, topology.bottom, topology.left, topology.right, 1

^~~~~~~~~~~~~~

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2846:59: note: insert an
explicit cast to silence this issue

topology.top, topology.bottom, topology.left, topology.right, 1

^~~~~~~~~~~~~~

static_cast<uint32_t>( )

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:3677:41: warning:
comparison of integers of different signs: 'uint32_t' (aka 'unsigned
int') and 'const int' [-Wsign-compare]

if (message->data.data32[0] == OnAllDesktops) {

~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~

2 warnings and 4 errors generated.

gmake[2]: *** [src/CMakeFiles/KF5WindowSystem.dir/build.make:495:
src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/netwm.cpp.o] Error
1

gmake[2]: *** Waiting for unfinished jobs....

gmake[1]: *** [CMakeFiles/Makefile2:153:
src/CMakeFiles/KF5WindowSystem.dir/all] Error 2

gmake: *** [Makefile:141: all] Error 2

[Pipeline] }

[Pipeline] // stage

[Pipeline] }

ERROR: script returned exit code 1

[Pipeline] // catchError

[Pipeline] sh

[Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9] Running shell
script

+ python3.5 -u ci-tooling/helpers/capture-workspace.py
--environment production

[Pipeline] emailextrecipients

[Pipeline] emailext



Links:
------
[1]
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/15/

Reply via email to