ngraham added a comment.

  In D6313#238605 <https://phabricator.kde.org/D6313#238605>, @acrouthamel 
wrote:
  
  > I think both of us missed this part at the bottom of @broulik's description:
  >
  > > This way you designers can now create dedicated 2x SVGs for those 
usecases, ie. we can have a 16px icon as well as a 16px@2x icon rather than it 
just taking the 32px icon which might not fit. In case a 16px@2x icon is not 
present it will load the 32px icon instead as it did before. This way one could 
even create a high dpi Oxygen theme.
  >
  > So #Breeze <https://phabricator.kde.org/tag/breeze/> will show the hi-res 
icons like it does now since it doesn't have any @2x folders or symlinks (an 
example of that can be found in Papirus 
<https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/tree/master/Papirus>).
 Moving forward, #Breeze <https://phabricator.kde.org/tag/breeze/> could create 
these @2x folders, populating them with beautiful Hi-DPI-acceptable icons, or 
whatever they want, to ensure interface consistency.
  >
  > But for now, it would be status-quo, even with this patch committed. So no 
one will notice, except those of us with @2x-compatible, 3rd party icon themes 
right now.
  
  
  Oops, so I did. Let me actually test this before I run my mouth any more...
  
  [goes to apply the patch]
  
  Kai, could you re-base this on master so it applies?

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Reply via email to