ngraham added inline comments.
INLINE COMMENTS
> SessionManagementScreen.qml:66
>
> -
> UserList {
Unrelated whitespace change
> LockScreenUi.qml:130
>
> -
> StackView {
Unrelated whitespace change
> LockScreenUi.qml:224
> + anchors.fill: parent
> + color: wallpaperFader.lightBackground ? Qt.rgba(1, 1, 1, 1,
> 0.2) : Qt.rgba( 0, 0, 0, 0.2)
> + Behavior on opacity {
The first `Qt.rgba()` has five arguments
> LockScreenUi.qml:270
> + }
> + PropertyChanges {
> + target: clockShadow
Indentation
> LockScreenUi.qml:329
> + samples: 32
> + color: Qt.rgba(0, 0, 0, 1)
> + Behavior on opacity {
FWIW, adding `spread: 0.2` improves the clarity against busy backgrounds a bit
for me.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D11928
To: mart, #plasma, #vdg, ngraham
Cc: richardbowen, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
