drosca requested changes to this revision.
drosca added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ListItemBase.qml:284
> menuItem.clicked.connect(function() {
> + paSinkModel.pendingPreferredSinkChange = true;
> PulseObject.default = true
It's possible that changing the sink will fail and `pendingPreferredSinkChange`
will stay `true` until next sink change (which may not be user-initiated).
> main.qml:158
> + onPreferredSinkChanged: {
> + if (pendingPreferredSinkChange) {
> + pendingPreferredSinkChange = false;
It won't work when default sink is changed from KCM, so I think let's just show
the OSD every time (except startup)?
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D12083
To: broulik, #plasma, #vdg, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
