broulik created this revision.
broulik added reviewers: Plasma, VDG, Fuchs.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  You can load custom icons through icon dialog, so support non-square icons 
just like Kicker does. Code mostly from Kicker.

TEST PLAN
  F5805902: Screenshot_20180412_211813.png 
<https://phabricator.kde.org/F5805902>
  
  - Size is sane in both vertical and horizontal panel
  - Square icons (and the default one) are still rounded to icon size
  - Verified with kolourpaint that square icon looks identical with and without 
this patch (I still fear there might be a "icon washed out" or "frizzled" 
regression somehow caused by this on low dpi screens (but who doesn't have a 8K 
monitor these days)
  - Changing icon updates size at runtime
  - Resizing panel updates size immediately

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12161

AFFECTED FILES
  applets/kickoff/package/contents/ui/Kickoff.qml

To: broulik, #plasma, #vdg, Fuchs
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to