davidedmundson added inline comments.

INLINE COMMENTS

> WallpaperFader.qml:4
> +
> +Copyright (C) 2014 Aleix Pol Gonzalez <aleix...@blue-systems.com>
> +

C&P?

> LockScreenUi.qml:76
> +        property bool uiVisible: false
> +        property bool blockUI: mainStack.depth > 1 || 
> mainBlock.mainPasswordBox.text.length > 0 || inputPanel.keyboardActive || 
> wallpaperIntegration.pluginName == "org.kde.color"
> +Text {

Is there any more generic solution possible?

> LockScreenUi.qml:77
> +        property bool blockUI: mainStack.depth > 1 || 
> mainBlock.mainPasswordBox.text.length > 0 || inputPanel.keyboardActive || 
> wallpaperIntegration.pluginName == "org.kde.color"
> +Text {
> +    text: wallpaperIntegration.pluginName

is this debug?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mart/newlockscreen

REVISION DETAIL
  https://phabricator.kde.org/D11928

To: mart, #plasma, #vdg, ngraham
Cc: abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Reply via email to