broulik added inline comments. INLINE COMMENTS
> models.h:47 > > - ~AbstractModel() override; > + virtual ~AbstractModel() override; > QHash<int, QByteArray> roleNames() const Q_DECL_FINAL; The `override` is sufficient > models.h:81 > +private: > + void *d; > }; Why `void*`? > models_p.h:26 > + > +class AbstractModelPrivate > +{ Do we need an explicit `Q_DECL_HIDDEN` or something? REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D12481 To: nicolasfella, drosca, apol Cc: broulik, apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart