roberts marked an inline comment as done. roberts added inline comments. INLINE COMMENTS
> wbauer wrote in opengl.cpp:211 > Using just "/driver" (instead of "/driver/module") makes it display "radeon" > instead of "drm" here as I would expect. > > OTOH, as it already runs lspci to get the other information, wouldn't it be > better to get the kernel module from lspci as well? > Additionally specifying the '-k' parameter to lspci adds these two lines to > lspci's output here: > Driver: radeon > Module: radeon > (the first one is the driver in use, the second one lists all available > modules for that device, see also "man lspci") > That should be independent of the kernel version and also work the same in > the get_dri_device_proc() case. > > Just a thought though. Have changed to use `/driver` instead of `/driver/module`. Am preferring to err on the side of not adding more numbered line reads from lspci output. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D12476 To: roberts, #plasma Cc: wbauer, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
