yurchor created this revision. yurchor added reviewers: Plasma, kde-i18n-doc. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. yurchor requested review of this revision.
REVISION SUMMARY According to this comment: https://marc.info/?l=kde-i18n-doc&m=152672268226040&w=2 TRANSLATION_DOMAIN in CMakeLists.tx is not enough to make QML code translatable. This can be easily tested using Neon: https://files.kde.org/neon/images/neon-devedition-gitunstable/current/ This revision is trying to mitigate this issue with minimal changes in the code. TEST PLAN 1. Run Neon with some ~100% translation package (sv or uk). 2. Rename translation catalogs as follows: kcmlaunchfeedback -> kcm_launchfeedback kcmtranslations -> kcm_translations kcm5_workspace -> kcm_workspace 3. Test if icons, launchfeedback, translations, and workspaceoptions modules are translated. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12982 AFFECTED FILES kcms/icons/main.cpp kcms/launch/CMakeLists.txt kcms/launch/Messages.sh kcms/translations/CMakeLists.txt kcms/translations/Messages.sh kcms/workspaceoptions/CMakeLists.txt kcms/workspaceoptions/Messages.sh To: yurchor, #plasma, kde-i18n-doc Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
