broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, fvogt.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When a tab becomes audible (ie. the playing sound icon shows up), register 
all players on the site.
  This ensures dynamically created players that weren't registred by our DOM 
mutation observer are also handled.

TEST PLAN
  Opened a twitter video, I clicked on it so it started playing with sound, now 
I can control it. Previously it would not detect it.
  
  Could also cause unintended side-effects if another tab starts playing sound 
suddenly?
  
  I don't fully understand why neither `createElement` nor the mutation 
observer detect it, though.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D12996

AFFECTED FILES
  extension/content-script.js
  extension/extension.js

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to