davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> browserintegrationreminder.cpp:129
>
> + m_watcher = new QDBusServiceWatcher(s_dbusServiceName, bus,
> QDBusServiceWatcher::WatchForRegistration, this);
> + connect(m_watcher, &QDBusServiceWatcher::serviceRegistered, this,
> [this](const QString &service) {
technically best to move this above the check for isServiceRegistered and you
avoid the slim race possibility.
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D13210
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
