davidedmundson added inline comments.
INLINE COMMENTS
> main.qml:98
> + onActiveTaskChanged: {
> + root.active = false;
> + root.minimizedClients = [];
Oh!
The old c++ plugin had deactivate(bool) where the parameter indicated whether
we restored the minimised windows or not. I had completely misread the old
behaviour.
onVirtualDesktopChanged: deactivate()
onActivityChanged: deactivate()
should be doing what you're doing here not calling deactivate().
Can you change those, then ++++ to that specific change.
(BUG: 395519)
---
as for onDataChanged vs onActiveTaskChanged
The reason I did this was if you click minimise all -> then click on the
desktop we deactivate, something I don't think we want.
I don't fully understand what you're saying is wrong with the onDataChanged.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D13529
To: anthonyfieroni, davidedmundson, #plasma
Cc: hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
