zzag added inline comments.
INLINE COMMENTS
> breezesizegrip.cpp:54
> // mask
> - QPolygon p;
> - p << QPoint( 0, GripSize )
> - << QPoint( GripSize, 0 )
> - << QPoint( GripSize, GripSize )
> - << QPoint( 0, GripSize );
> + QPolygon p = QVector<QPoint>{
> + QPoint( 0, GripSize ),
Can be const.
> breezesizegrip.cpp:150
> // polygon
> - QPolygon p;
> - p << QPoint( 0, GripSize )
> - << QPoint( GripSize, 0 )
> - << QPoint( GripSize, GripSize )
> - << QPoint( 0, GripSize );
> + QPolygon p = QVector<QPoint> {
> + QPoint( 0, GripSize ),
Can be const.
> breezeshadowhelper.cpp:461-464
> + const quint32 topSize = margins.top();
> + const quint32 bottomSize = margins.bottom();
> + const quint32 leftSize( margins.left() );
> + const quint32 rightSize( margins.right() );
Not the best thing. But shadows in Breeze have positive margins so that's okay.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D13591
To: tcanabrava, #breeze
Cc: ngraham, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
