broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY There's no point in loading the entire module when automounting is disabled. It does Solid device queries which can be quite expensive, albeit it delays initialization. The `AutomounterSettings::shouldAutomountDevice` function allows force-mounting even if automounting as a whole is disabled whereas the KCM UI does not. Not sure what the reason for that is. TEST PLAN Enabled setting in KCM, kded module was loaded. Disabled setting in KCM, kded module was unloaded. Changed the rc file manually, started kded, it unloaded itself and didn't load again next time. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13852 AFFECTED FILES solid-device-automounter/kcm/CMakeLists.txt solid-device-automounter/kcm/DeviceAutomounterKCM.cpp solid-device-automounter/kded/CMakeLists.txt solid-device-automounter/kded/DeviceAutomounter.cpp solid-device-automounter/kded/device_automounter.desktop To: broulik, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
