zzag added inline comments.

INLINE COMMENTS

> xrandr.cpp:273
>          if (len % 128 == 0) {
> -            return result;
> -        } else {
> -            len = 0;
> -            delete[] result;
> +            edid = QByteArray((char *) result, len);
>          }

reinterpret_cast<char*>(result)

> xrandr.cpp:275
>          }
> +        delete[] result;
>      }

It would be great to use QScopedPointer, but that would be unrelated change, I 
guess.

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14044

To: gladhorn, #plasma, davidedmundson
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to