drosca added inline comments.
INLINE COMMENTS
> CMakeLists.txt:46
> +
> +if(USE_GCONF AND USE_GSETTINGS)
> + message(FATAL_ERROR "USE_GCONF and USE_GSETTINGS cannot be used at the
> same time")
This should probably use cache variables:
set(USE_GCONF FALSE CACHE STRING "Build with GConf")
set(USE_GSETTINGS TRUE CACHE STRING "Build with GSettings")
> gsettingsitem.cpp:22
> +#include <QVariant>
> +#include <QDebug>
> +
not needed
> gsettingsitem.cpp:26
> +
> +#include "gsettingsitem.h"
> +#include "debug.h"
local includes should be the first in file
> gsettingsitem.cpp:40
> + case G_VARIANT_CLASS_STRING:
> + toReturn = QVariant(QString::fromUtf8(g_variant_get_string(gvalue,
> NULL)));
> + break;
nullptr
> gsettingsitem.cpp:53
> +{
> +
> + // It might be hard to detect the right GVariant type from
newline
> gsettingsitem.cpp:63
> + switch (g_variant_type_peek_string(g_variant_get_type(oldValue))[0]) {
> + case G_VARIANT_CLASS_BOOLEAN:
> + newValue = g_variant_new_boolean(val.toBool());
indentation
> gsettingsitem.cpp:73
> +
> + if (newValue)
> + g_settings_set_value(m_settings, key.toLatin1().data(), newValue);
braces
> gsettingsitem.cpp:82
> +{
> +
> + m_settings =
> g_settings_new_with_path("org.freedesktop.pulseaudio.module-group",
> key.toLatin1().data());
newline
> gsettingsitem.cpp:91
> + g_settings_sync();
> + if (m_settings)
> + g_object_unref(m_settings);
braces
> gsettingsitem.h:34
> + public:
> +
> + explicit GSettingsItem(const QString &key, QObject *parent = nullptr);
newline
> gsettingsitem.h:41
> +
> +
> +Q_SIGNALS:
newline
> gsettingsitem.h:48
> +
> +static void settingChanged(GSettings *settings, const gchar *key, gpointer
> data)
> +{
move to .cpp
> modulemanager.cpp:93
> +#if USE_GCONF || USE_GSETTINGS
>
> + m_combineSinks = new ConfigModule(QStringLiteral("combine"),
> QStringLiteral("module-combine"), this);
newline
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D14147
To: nicolasfella, drosca, davidedmundson
Cc: rikmills, broulik, asturmlechner, plasma-devel, ragreen, Pitel, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
