abetts added a comment.
In D15011#315863 <https://phabricator.kde.org/D15011#315863>, @ngraham wrote: > In D15011#315816 <https://phabricator.kde.org/D15011#315816>, @abetts wrote: > > > I agree that our HIG needs to explain focus better. It doesn't really have to be a long HIG about it. It could just be a general rule about the way that fields get their focus. In my mind, adding a visual element that denotes focus is a bit unnecessary, unless you navigate your UI using TAB or this is actually a user with an explicit need to see where the focus is. > > > > My general opinion is that KDE has wanted every nook and cranny to have importance and we reflect that in the UI. Like the Kirigami HIG says, developers need to find the most important controls about their app UI and give those a certain priority. I think we could apply that here and remove the blue circle from the search fields and only make it show when the user is navigating using tab or because of some accessibility feature. I don't think that just because it is present in many areas, that it means it's the better approach. However, I remain open to the general consensus. > > > I think we'd need to be careful playing with this. In some cases, I would agree with you that a focus ring is unnecessary--for example around the main content view in Dolphin or Kate: it's obvious where focus is because of the underlined/selected files, or the blinking cursor (respectively). But for small text fields, I think it probably adds value. The important thing is that the user feels confident regarding what will be affected when they use their keyboard. That's why visible focus indicators exist. Our focus indicator is already pretty subtle compared to other platforms. We change a one-pixel monochrome line to a one-pixel colored line. On macOS, for example, there's a huge blue glow. > > Also note that if we want to change the focus indicator in Breeze, then we should land this patch as-is and not tweak the focus behavior here or else we may not automatically inherit whatever changes we make globally. Interesting. I can change my opinion here. Should we then make sure that all the examples shown in the table behave the same? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson, abetts Cc: huftis, rooty, sharvey, romangg, broulik, safaalfulaij, oysteins, filipf, abetts, davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
