andersonbruce added a comment.
In D15093#315875 <https://phabricator.kde.org/D15093#315875>, @ngraham wrote: > Wow, what a first patch! And you even used `arc` too, how nice. > > Since this fixes https://bugs.kde.org/show_bug.cgi?id=397572, can you indicate it as such in the Summary section per https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords? > > Just add the following to the Summary section: > > FEATURE: 397572 > FIXED-IN: 5.14.0 > Done > In addition, I see one coding style issue right off the bat: we don't put opening braces on their own lines. That'll need to be changed in all the filed you've added. And speaking of those added files, I think you need to add your copyright to them. Finally, do we really need to duplicate `passwordfield.h` and `passwordfield.cpp`? I will start fixing the brace style. This started off just for my own use so I'm afraid I didn't pay much attention to existing styles, my apologies. As far as the 'passwordfield' files, this was just laziness on my part, it being easier to just copy them than figure out how to get cmake (another tool I haven't used much) to add the correct include path to the flags. Any pointers on how to do this correctly would be appreciated. As to copyright notice, I see that most are listed with name and email address. Is the latter expected or is just name enough? I don't have a business email anymore and I am somewhat hesitant to use my personal address but can if it is expected. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D15093 To: andersonbruce, #plasma, jgrulich Cc: lbeltrame, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
