cgiboudeaux added inline comments.
INLINE COMMENTS
> FindQt5PlatformSupport.cmake:72
> + PATH_SUFFIXES
> + QtPlatformSupport/${Qt5Core_VERSION}/
> )
This CMake module doesn't know Qt5Core_VERSION, this only works for you because
there's a find_package(Qt5 ...) call before looking for Qt5PlatformSupport
> FindQt5PlatformSupport.cmake:76
> +if (Qt5PlatformSupport_INCLUDE_DIR)
> + set(Qt5PlatformSupport_VERSION ${Qt5Core_VERSION})
> +else()
Same here
> FindQt5ThemeSupport.cmake:73
> + PATH_SUFFIXES
> + QtThemeSupport/${Qt5Core_VERSION}/
> )
Same here
> FindQt5ThemeSupport.cmake:77
> +if (Qt5ThemeSupport_INCLUDE_DIR)
> + set(Qt5ThemeSupport_VERSION ${Qt5Core_VERSION})
> +else()
Same here
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D15310
To: sdepiets, lbeltrame, #plasma, cgiboudeaux
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
