mart added a comment.
wrt position of desktopAdded and eventual reorders.. in the desktop data, x11DesktopNubmer is always guaranteed to be the correct position (modulo the annoying off by one due to x11 desktops) INLINE COMMENTS > desktopsmodel.cpp:295 > + > + // FIXME TODO: Positions are currently not zero- but one-indexed in > KWin it seems. > + call.setArguments({(uint)newIndex, > m_names.value(m_desktops.at(newIndex - 1))}); this is for retrocompatibility with x11 desktops, where they are 1 indexed for some obscure reason. 1 has been kept elsewhere to not make kwin code even more confusing and error prone REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14542 To: hein, mart, davidedmundson Cc: abetts, davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart