ngraham added a comment.
Nah, you did great! The only thing you could have done to make this easier would have been to submit two patches: one to templatize the code, and a second one to make functional changes. But Phabricator makes this workflow somewhat awkward and more difficult than it needs to be compared to Github for example, so I can understand why you didn't. Thanks again for your valuable contribution, and I think this will probably make it into Plasma 5.15! REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D16365 To: ohelin, jackg, #breeze, #plasma, ngraham Cc: grmat, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
