zzag added inline comments.

INLINE COMMENTS

> desktopsmodel.cpp:253
> +
> +        call.setArguments({m_desktops.last()});
> +

Is m_desktops.last() the right one? It can be already deleted.

For example, If user has two virtual desktops:

- Desktop 1
- Pizza

and he or she wants to delete virtual desktop called "Pizza", then Desktop 1 
will be removed instead.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

Reply via email to