fvogt added inline comments. INLINE COMMENTS
> extension.js:156 > + if (chrome.runtime.lastError) { > + // failed to create entry, most likely visibility change before > device added was processed > + return; Can you explain how that makes the creation fail? > kdeconnectplugin.cpp:155 > +{ > + if (!m_devices.contains(deviceId)) { > + return; You could just do if(m_devices.removeOne(deviceId)) sendData(...) if the order of removing and sendData is not important. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D16889 To: broulik, #plasma, davidedmundson, fvogt, nicolasfella Cc: apol, bruns, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart