davidedmundson added a comment.
Ship it if you like, but I think there's a nicer solution.
INLINE COMMENTS
> greeterapp.cpp:313
> // on error, load the fallback lockscreen to not lock the user out
> of the system
> - if (view->status() == QQmlComponent::Error) {
> + if (view->status() == QQmlComponent::Error ||
> m_mainQmlPath.isEmpty()) {
> static const QUrl
> fallbackUrl(QUrl(QStringLiteral("qrc:/fallbacktheme/LockScreen.qml")));
> view->status() != Ready
should also work, and that covers the case of m_mainQmlPath being set but
pointing to an empty file.
We'll never be loading as all files should be local.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D16945
To: graesslin, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
