davidedmundson added inline comments. INLINE COMMENTS
> hein wrote in GroupDialog.qml:265 > The suggested code is the same as the present code, so not sure ... can you > clarify? > > The aboutToPopulate thing is done for the focus-active-task. I'm not sure I > want to replace this with `callLater`, since callLater has weakly defined > semantics for me tastes. For the `updateSize` case only eventual consistency > counts. If it was executed too early and then later again it'd at worst be > more like the old performance, but not break things. With the > focus-active-task code, though, it could break things. My line changes || -> && REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D17006 To: hein, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
