ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  The Layout and Wallpaper Type comboboxes should open on press, not on 
click-and-release.
  
  The Positioning combobox shouldn't be so much much wider than the other 
comboboxes; the text of the longest item doesn't seem long enough to cause such 
a long width.
  
  Is changing the wallpaper plugins button even necessary for this patch? If 
you think it is, instead of making the wallpaper plugin button icons-only, can 
we move it to the bottom row with the other GHNS button?
  
  Either way, this patch now fixes https://bugs.kde.org/show_bug.cgi?id=401472 
so please add:
  
    BUG: 401472
    FIXED-IN: 5.15.0

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17211

To: mart, #plasma, #vdg, broulik, ngraham
Cc: ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

Reply via email to