davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
If Nate and Andy say to use this icon, go for it.
One code change
INLINE COMMENTS
> main.qml:58
> imagePath: "widgets/configuration-icons"
> - onRepaintNeeded: toolBoxIcon.elementId =
> iconSvg.hasElement("menu") ? "menu" : "configure"
> + onRepaintNeeded: toolBoxIcon.elementId = "configure"
> }
This doesn't make sense..
We're re-evaulating because hasElement might have changed when switching themes.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D17321
To: GB_2, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, abetts, ngraham, #vdg, plasma-devel, #plasma,
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, Pitel,
crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed,
jensreuterberg, aaronhoneycutt, sebas, apol, mbohlender, mart
