ngraham added a reviewer: VDG.
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
@gepardo I'm very sorry that you haven't gotten any real feedback on this
yet. :( The maintainer seems to have vanished. I will CC come more people and
have a go at reviewing it myself.
One thing that's definitely going to need to change is that if since you've
added build dependencies, this needs to be reflected in `CMakeLists.txt`,
because right now, running your `rebuild_theme.sh` simply doesn't work without
the new dependency:
$ (arcpatch-D17154) ./rebuild-theme.sh
./build_theme.sh: 18: ./build_theme.sh: sass: not found
./build_theme.sh: 18: ./build_theme.sh: sass: not found
./build_theme.sh: 18: ./build_theme.sh: sass: not found
./build_theme.sh: 18: ./build_theme.sh: sass: not found
On that subject, rebuilding the theme should be done as a part of the default
build target when running `make` rather than requiring the use of a script.
It's a requirement that all the work gets done simply by running `make`. This
will require a few CMake adjustment too.
Can you make these changes?
REPOSITORY
R98 Breeze for Gtk
REVISION DETAIL
https://phabricator.kde.org/D17154
To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
