thsurrel marked 6 inline comments as done.
thsurrel added inline comments.

INLINE COMMENTS

> broulik wrote in DeviceItem.qml:92
> Can we assume "action" is always unmount?

If the device is removable and mounted, than the action can only be unmounting, 
yes.

> broulik wrote in FullRepresentation.qml:113
> Why this change? `ColumnLayout` should layout everything automatically 
> without the need for nachors

I do not manage to get the layout I want with ColumnLayout: I need to align 
that ScrollArea to the same level than the 'unmountAll' button

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_unmountall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16212

To: thsurrel, #plasma, #vdg, ngraham
Cc: broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to