enriquem updated this revision to Diff 49911. enriquem added a comment.
I addressed your comments, except the ones regarding macro definitions, since I am unsure thar applicable versions of openconnect have compatible parameters. I will find out and revisit the comment later CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=49906&id=49911 REVISION DETAIL https://phabricator.kde.org/D18394 AFFECTED FILES vpn/openconnect/CMakeLists.txt vpn/openconnect/nm-openconnect-service.h vpn/openconnect/openconnectauth.cpp vpn/openconnect/openconnectauth.h vpn/openconnect/openconnectauthworkerthread.cpp vpn/openconnect/openconnectauthworkerthread.h vpn/openconnect/openconnectprop.ui vpn/openconnect/openconnecttoken.ui vpn/openconnect/openconnectwidget.cpp vpn/openconnect/openconnectwidget.h To: enriquem, jgrulich Cc: pino, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
