broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY The button effectively saves the theme to be edited as a new file, so turn it into a "Save As" button that is always shown. TEST PLAN Editing a system color scheme that you cannot overwrite F6567497: Screenshot_20190125_124805.png <https://phabricator.kde.org/F6567497> Editing a user color scheme, "Save As" allows to save it as a new theme, Apply just applies the changes to the edited theme F6567498: Screenshot_20190125_124815.png <https://phabricator.kde.org/F6567498> The Apply button is only shown when the `--overwrite` option is passed to kcolorscheme, passed by the KCM for user themes. I just figured, perhaps it makes more sense to check file permissions (it only does that once you actually hit Save) and show the Apply button based on that REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18519 AFFECTED FILES kcms/colors/editor/kcolorschemeeditor.cpp kcms/colors/editor/scmeditordialog.cpp kcms/colors/editor/scmeditordialog.h To: broulik, #plasma, #vdg Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
