ognarb added inline comments.

INLINE COMMENTS

> broulik wrote in SearchField.qml:44
> I think this is fine but may need a translation domain 
> `i18nd("whatever_domain_kirigami_uses", "Search...")`

Are you sure? It would mean that Kirigami should then depends on ki18n. And 
them Kirigami wouldn't be a Tier 1 KDE framework anymore.

@mart should I move this in the example code or it is fine with a translation 
domain?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19502

To: ognarb, #kirigami, ngraham, mart
Cc: broulik, apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

Reply via email to