ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > KNSBackend.cpp:68 > QVector<AbstractResourcesBackend*> ret; > - for (const QString &path: > QStandardPaths::standardLocations(QStandardPaths::GenericConfigLocation)) { > +#if KNEWSTUFFCORE_VERSION_MAJOR==5 && KNEWSTUFFCORE_VERSION_MAJOR>=56 > + QStringList locations = KNSCore::Engine::configSearchLocations(); Needs to be 57 now (we'll get all of this landed soon, not to worry!) Also, should the second one be `KNEWSTUFFCORE_VERSION_MINOR`? Seems weird that both conditions are checking the major version. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19340 To: leinir, #discover_software_store, apol, ngraham Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart