davidedmundson added a comment.

  Thanks

INLINE COMMENTS

> process.h:215
>  
> +    QString& cGroup() const; // REF, make non-ref later!
> +    void setCGroup(const QString &cGroup); ///< Linux Control Group (cgroup)

may as well make it non-ref now.

I assume that ref pattern existed as an old way of sscanf-ing directly into the 
member variables skipping the setBlah call.

> ProcessModel.cpp:1035
> +            case HeadingCGroup:
> +                return i18n("<qt>The control group (cgroup) where this 
> process was belongs.</qt>");
>              default:

> The control group (cgroup) where this process was belongs.

That doesn't scan right.

s/was //   ?

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D20787

To: topimiettinen, #plasma, hein
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

Reply via email to