ngraham created this revision. ngraham added reviewers: VDG, Plasma, kossebau. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision.
REVISION SUMMARY - Port to QQC2+Kirigami FormLayout style - Adjust some strings to sound a bit more natural - Hide "Compact Mode" header since all the settings currently apply to compact mode; it only makes sense to display this when there's an additional mode to contrast with it TEST PLAN Weather station page, before selecting a station: F6800189: Weather station - before choosing.png <https://phabricator.kde.org/F6800189> Weather station page, after selecting a station: F6800190: Weather station - after choosing.png <https://phabricator.kde.org/F6800190> Appearance page: F6800192: Appearance.png <https://phabricator.kde.org/F6800192> Units page: F6800193: Units.png <https://phabricator.kde.org/F6800193> The blank Visibility combobox is a pre-existing bug not introduced (or fixed) with this patch. REPOSITORY R114 Plasma Addons BRANCH modernize-settings-window (branched from master) REVISION DETAIL https://phabricator.kde.org/D20896 AFFECTED FILES applets/weather/package/contents/ui/config/ConfigAppearance.qml applets/weather/package/contents/ui/config/ConfigUnits.qml applets/weather/package/contents/ui/config/ConfigWeatherStation.qml To: ngraham, #vdg, #plasma, kossebau Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
