ngraham added a comment.
I don't like hardcoding the things we're comparing against. If we ever add more colors besides "black" or "translucent-light", or of the actual color values of those change (unlikely, but possible), all these buttons will need their code to be adjusted and that'll be easy to forget. I feel like we should be programmatically sampling the background color itself. Also, if you're ever tempted to duplicate the same logic several times, that's a sure sign it should be in a function. Then each button can just call that function. Finally porting from PlasmaComponents to QQC2 seems unrelated (or at least the relationship isn't clear from the description). Maybe we should first do that separately. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D21027 To: filipf, #plasma, #vdg, ngraham Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
