johngehrig updated this revision to Diff 57581. johngehrig edited the summary of this revision. johngehrig edited the test plan for this revision. johngehrig added a comment.
Ordering changed, qWarning first. job->errorString() displayed for all values of job->error(). A QString object was created, so job is no longer passed to KMessageBox. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20859?vs=57081&id=57581 REVISION DETAIL https://phabricator.kde.org/D20859 AFFECTED FILES sddmthemeinstaller.cpp To: johngehrig, ngraham, davidedmundson, #plasma Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart